Added Fast Inverse Square Root#11054
Merged
cclauss merged 8 commits intoTheAlgorithms:masterfrom Oct 29, 2023
Merged
Conversation
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
added
awaiting reviews
cclauss
reviewed
Oct 29, 2023
cclauss
reviewed
Oct 29, 2023
maths/fast_inverse_sqrt.py
Outdated
Comment on lines
20
to
24
| >>> fastInvSqrt(10) | ||
| 0.3156857923527257 | ||
|
|
||
| >>> fastInvSqrt(4) | ||
| 0.49915357479239103 |
Member
There was a problem hiding this comment.
Suggested change
| >>> fastInvSqrt(10) | |
| 0.3156857923527257 | |
| >>> fastInvSqrt(4) | |
| 0.49915357479239103 | |
| >>> fast_inverse_sqrt(10) | |
| 0.3156857923527257 | |
| >>> fast_inverse_sqrt(4) | |
| 0.49915357479239103 | |
| >>> fast_inverse_sqrt(0) | |
| ??? | |
| >>> fast_inverse_sqrt(-4) | |
| ??? | |
| >>> fast_inverse_sqrt(4.1) | |
| ??? | |
| >>> from math import sqrt | |
| >>> all(fast_inverse_sqrt(i) == sqrt(i) for i in range(-10, 10)) | |
| True |
cclauss
requested changes
Oct 29, 2023
Member
cclauss
left a comment
cclauss
left a comment
There was a problem hiding this comment.
Add some doctests that break things.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/fast_inverse_sqrt.py
Outdated
| import struct | ||
|
|
||
|
|
||
| def fast_inverse_sqrt(x: float) -> float: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
algorithms-keeper
bot
removed
the
awaiting changes
algorithms-keeper
bot
removed
the
require descriptive names
for more information, see https://pre-commit.ci
Contributor
Author
|
The test may/may not fail due to the approximation of answer, which is the essence of this method. Pls review for any additional change. |
Member
|
As discussed in CONTRIBUTING.md you can run the tests on your own computer with: |
Contributor
Author
The doctests work perfectly on my PC, even before i committed. In the build fail details,
|
algorithms-keeper
bot
removed
the
tests are failing
cclauss
approved these changes
Oct 29, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: