Add doctests for fractional knapsack#10891
Merged
cclauss merged 5 commits intoTheAlgorithms:masterfrom Oct 24, 2023
Merged
Conversation
15 tasks
15 tasks
cclauss
reviewed
Oct 24, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
Member
|
On your computer do |
Contributor
Author
|
I have successfully executed the doctests, yielding the following output: 11 tests in fractional_knapsack.frac_knapsack |
cclauss
reviewed
Oct 24, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
Contributor
Author
|
After adding this test case, this is the output: 1 items had failures: This suggests that the existing code cannot handle the case when the input parameters are of another unexpected type (string). |
cclauss
reviewed
Oct 24, 2023
cclauss
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added doctests for the Fractional Knapsack algorithm, as requested in PR #10888
Checklist: