Happy number (new algorithm)#10864
Merged
cclauss merged 18 commits intoTheAlgorithms:masterfrom Oct 30, 2023
Merged
Conversation
adding new algorithm
for more information, see https://pre-commit.ci
Contributor
Author
|
@cclauss Kindly review this PR. I added new algorithm in Special numbers section. |
cclauss
reviewed
Oct 30, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
require type hints
Contributor
Author
|
@cclauss resolved the issue. Kindly review it |
cclauss
reviewed
Oct 30, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
added ValueError part in code
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
Contributor
Author
|
@cclauss raised ValueError("number is not a positive integer"). Kindly review it. |
modified and added raise Error code
for more information, see https://pre-commit.ci
cclauss
approved these changes
Oct 30, 2023
algorithms-keeper
bot
removed
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding new algorithm
Describe your change:
Checklist: