Added doctests for fibonacci.py #10836
Merged
cclauss merged 11 commits intoTheAlgorithms:masterfrom Oct 29, 2023
Merged
Conversation
removed whitespace
for more information, see https://pre-commit.ci
Contributor
Author
|
Hold on, doctest seems to not be testing the function in question, I believe it's because it's a nested function. I'll need to figure something out for that. Sorry for not checking this properly. |
Contributor
Author
|
I closed this pull request as I realised doctest wasn't properly testing the function ( However I found out that doctests doesn't test local functions, which was the function I implemented doctests for. So I'm reopening this pull request to ask whether we need to implement a way doctest will actually test that function, or just merge it anyways as the doctests are working (I've tested the function in a separte isolated file). |
cclauss
approved these changes
Oct 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
#9943
Added doctests for the fib_recursive_term function in maths/fibonacci.py
Checklist: