Delete arithmetic_analysis/ directory and relocate its contents#10824
Merged
cclauss merged 3 commits intoTheAlgorithms:masterfrom Oct 23, 2023
Merged
Delete arithmetic_analysis/ directory and relocate its contents#10824cclauss merged 3 commits intoTheAlgorithms:masterfrom
arithmetic_analysis/ directory and relocate its contents#10824cclauss merged 3 commits intoTheAlgorithms:masterfrom
Conversation
Delete the arithmetic_analysis/ directory and relocate its files because the purpose of the directory was always ill-defined. "Arithmetic analysis" isn't a field of math, and the directory's files contained algorithms for linear algebra, numerical analysis, and physics. Relocated the directory's linear algebra algorithms to linear_algebra/, its numerical analysis algorithms to a new subdirectory called maths/numerical_analysis/, and its single physics algorithm to physics/.
arithmetic_analysis/ directory and relocate its contents
cclauss
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #8863
Deleted the
arithmetic_analysis/directory and relocated its files because the purpose of the directory was always ill-defined. "Arithmetic analysis" isn't a known field of math, and the directory's files contained algorithms for linear algebra, numerical analysis, and even physics.Relocated the directory's linear algebra algorithms to
linear_algebra/, its numerical analysis algorithms to a new subdirectory calledmaths/numerical_analysis/, and its single physics algorithm tophysics/. Doing this revealed multiple duplicate algorithms that will need to be consolidated/deleted in future PRs.Incidentally, I also had to fix #8863 in this PR by removing all instances of
evalfromarithmetic_analysis/newton_raphson.pybecauseruffwouldn't let me commit my changes otherwise.Checklist: