Skip to content

optimized and corrected longest increasing subsequence problem#10725

Closed
Arunsiva003 wants to merge 15 commits intoTheAlgorithms:masterfrom
Arunsiva003:optimize
Closed

optimized and corrected longest increasing subsequence problem#10725
Arunsiva003 wants to merge 15 commits intoTheAlgorithms:masterfrom
Arunsiva003:optimize

Conversation

@Arunsiva003
Copy link
Contributor

@Arunsiva003 Arunsiva003 commented Oct 20, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Arunsiva003 and others added 15 commits October 14, 2023 18:17
@Arunsiva003
earliest deadline first scheduling algo added
76fd929
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4363669 
for more information, see https://pre-commit.ci
@Arunsiva003
earliest deadline first scheduling algo added
bbac298
@Arunsiva003
earliest deadline first scheduling algo added 2
4d156e5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
628b1b3 
for more information, see https://pre-commit.ci
@Arunsiva003
ceil and floor and bst
9397c73
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
31e43db 
for more information, see https://pre-commit.ci
@Arunsiva003
ceil and floor and bst 2
22f40d9
@Arunsiva003
ceil and floor and bst 2
1f6eed8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6238c4a 
for more information, see https://pre-commit.ci
@Arunsiva003
ceil and floor and bst 3
f845dd4
@Arunsiva003
Merge branch 'create' of https://github.com/Arunsiva003/Python into c…
f31b31e 
…reate
@Arunsiva003
Merge branch 'TheAlgorithms:master' into master
b7b7f3e
@Arunsiva003
Merge branch 'master' of https://github.com/Arunsiva003/Python into c…
242757a 
…reate
@Arunsiva003
optimized and corrected longest increasing subsequence problem
21dfa20
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 20, 2023
AasheeshLikePanner
AasheeshLikePanner reviewed Oct 22, 2023
View reviewed changes
data_structures/binary_tree/floor_ceil_in_bst.py
@@ -0,0 +1,82 @@
"""
Copy link
Contributor

@AasheeshLikePanner AasheeshLikePanner Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, You are also changing this file. Can you create the different pull request for different files.

AasheeshLikePanner
AasheeshLikePanner reviewed Oct 22, 2023
View reviewed changes
scheduling/shortest_deadline_first.py
@@ -0,0 +1,70 @@
"""
Copy link
Contributor

@AasheeshLikePanner AasheeshLikePanner Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, For this.

@tianyizheng02
Copy link
Contributor

tianyizheng02 commented Oct 22, 2023

Like @AasheeshLikePanner said, you're modifying an existing file as well as contributing multiple files in the same PR. You checked this checkbox, so you did acknowledge this:

  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

@tianyizheng02 tianyizheng02 added the multiple algorithms not allowed Multiple algorithms in a single PR are not allowed label Oct 22, 2023
@Arunsiva003
Copy link
Contributor Author

Arunsiva003 commented Oct 23, 2023

Like @AasheeshLikePanner said, you're modifying an existing file as well as contributing multiple files in the same PR. You checked this checkbox, so you did acknowledge this:

  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

I made a new PR...Kindly review it #10830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AasheeshLikePanner AasheeshLikePanner AasheeshLikePanner left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files multiple algorithms not allowed Multiple algorithms in a single PR are not allowed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Arunsiva003 @tianyizheng02 @AasheeshLikePanner

Comments