[ADD]: Improved tests in power recursion!#10664
Merged
cclauss merged 12 commits intoTheAlgorithms:masterfrom Oct 20, 2023
imSanko:master
Merged
[ADD]: Improved tests in power recursion!#10664cclauss merged 12 commits intoTheAlgorithms:masterfrom imSanko:master
cclauss merged 12 commits intoTheAlgorithms:masterfrom
imSanko:master
Conversation
Contributor
Author
|
@tianyizheng02 can you have a look |
cclauss
requested changes
Oct 19, 2023
Member
There was a problem hiding this comment.
Pull requests should either add/improve tests or should change the code. This PR changes both the tests and the code. This makes the PR much more difficult to review.
Please revert the change to the algorithm and the change of the filename. Let's have this pull request JUST focus on improving the testing.
@tianyizheng02 Perhaps we need to talk more in CONTRIBUTING.md about not changing both code and tests in a single PR.
Contributor
Author
|
@cclauss can you check the change, cause I've made the as per your choice. |
cclauss
approved these changes
Oct 20, 2023
Contributor
Author
|
@cclauss can you please add #hacktoberfest-accepted label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
[ADD]: New test cases for all_combinations !
Checklist: