Consolidate bubble sort iterative and recursive#10651
Merged
cclauss merged 5 commits intoTheAlgorithms:masterfrom Oct 19, 2023
R055A:consolidate-bubble-sort
Merged
Consolidate bubble sort iterative and recursive#10651cclauss merged 5 commits intoTheAlgorithms:masterfrom R055A:consolidate-bubble-sort
cclauss merged 5 commits intoTheAlgorithms:masterfrom
R055A:consolidate-bubble-sort
Conversation
cclauss
reviewed
Oct 17, 2023
cclauss
requested changes
Oct 17, 2023
Member
cclauss
left a comment
There was a problem hiding this comment.
- Fix function signature to be similar.
- Add a
timeitbenchmark to prove the relative performance.
- https://docs.python.org/3/library/timeit.html
- https://github.com/search?q=repo%3ATheAlgorithms%2FPython%20timeit
- Doctests should cover similar (or identical) test cases across both functions.
Co-authored-by: Christian Clauss <cclauss@me.com>
Contributor
Author
Hi @cclauss to my understanding, the requested changes have been completed. Let me know what you think, please |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Ref #8098
Merge
recursive_bubble_sortwithbubble_sort, renaming functions tobubble_sort_recursiveandbubble_sort_iterative, respectively.Checklist: