Dynamic programming/matrix chain multiplication#10562
Dynamic programming/matrix chain multiplication#10562cclauss merged 11 commits intoTheAlgorithms:masterfrom
Conversation
When would the algorithm be used in the real-world? |
|
Adding some real world applications of the algorithm in docstring. |
tianyizheng02
left a comment
tianyizheng02
left a comment
There was a problem hiding this comment.
Do you have an implementation of the algorithm for determining the actual order of multiplications? Simply knowing how many operations are needed isn't very useful and doesn't help with any of the real-world applications.
Add a non-dp solution with benchmarks.
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
| @cache | ||
| def a(i, j): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function a
Please provide return type hint for the function: a. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the function: a
Please provide type hint for the parameter: i
Please provide descriptive name for the parameter: i
Please provide type hint for the parameter: j
Please provide descriptive name for the parameter: j
|
|
||
|
|
||
| @contextmanager | ||
| def elapsed_time(msg: str) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function elapsed_time
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
| @cache | ||
| def a(i, j): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function a
Please provide return type hint for the function: a. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the function: a
Please provide type hint for the parameter: i
Please provide descriptive name for the parameter: i
Please provide type hint for the parameter: j
Please provide descriptive name for the parameter: j
|
|
||
|
|
||
| @contextmanager | ||
| def elapsed_time(msg: str) -> Iterator: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function elapsed_time
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
| @cache | ||
| def a(i, j): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function a
Please provide return type hint for the function: a. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the function: a
Please provide type hint for the parameter: i
Please provide descriptive name for the parameter: i
Please provide type hint for the parameter: j
Please provide descriptive name for the parameter: j
|
|
||
|
|
||
| @contextmanager | ||
| def elapsed_time(msg: str) -> Iterator: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function elapsed_time
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
| @cache | ||
| def a(i: int, j: int) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function a
Please provide descriptive name for the function: a
Please provide descriptive name for the parameter: i
Please provide descriptive name for the parameter: j
|
|
||
|
|
||
| @contextmanager | ||
| def elapsed_time(msg: str) -> Iterator: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/matrix_chain_multiplication.py, please provide doctest for the function elapsed_time
cclauss
left a comment
cclauss
left a comment
There was a problem hiding this comment.
The algorithm is framed in the same way on Wikipedia. There are two different algorithms with benchmarks.
algorithms-keeper
bot
removed
the
awaiting reviews
cclauss
dismissed
tianyizheng02’s stale review
The algorithm is framed in the same way on Wikipedia. There are two different algorithms with benchmarks.
3 participants
Describe your change:
Checklist:
P.s. I would like to add that I started by trying to add doctests to matrix_chain_order.py script under Python/dynamic_programming/matrix_chain_order in order to improve its test coverage. However, I found the functions poorly written. Instead of changing the code, I have written a separate script with bug free code, problem explanation and required doctests. Moderators may consider deleting matrix_chain_order.py. Creating new PR by deleting #10549 and #10561.