Skip to content

updated physics/archimedes_principle.py#10479

Merged
cclauss merged 34 commits intoTheAlgorithms:masterfrom
Baron105:archimedes
Oct 15, 2023
Merged

updated physics/archimedes_principle.py#10479
cclauss merged 34 commits intoTheAlgorithms:masterfrom
Baron105:archimedes

Conversation

@Baron105
Copy link
Contributor

@Baron105 Baron105 commented Oct 15, 2023

Describe your change:

modified physics/archimedes_principle.py
added some doctests for exception handling, imported g from scipy rather than hard coding and allowed zero gravity to be valid giving value 0 in that case

fixes issue #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Baron105 and others added 30 commits October 10, 2023 19:22
@Baron105
avg and mps speed formulae added
1427fe3
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0608c40 
for more information, see https://pre-commit.ci
@Baron105
avg and mps speed formulae added
7457b25
@Baron105
fixed_spacing
b1ef5a3
@Baron105
.
c957bd7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
07502c8 
for more information, see https://pre-commit.ci
@Baron105
spacing
ead4f47
@Baron105
.
c18b39d
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cb006c3 
for more information, see https://pre-commit.ci
@Baron105
ws
ab04734
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
69487f3
@Baron105
added amicable numbers
6a741dc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d13c09d 
for more information, see https://pre-commit.ci
@Baron105
Merge branch 'TheAlgorithms:master' into master
18df9ba
@Baron105
added amicable numbers
63734b9
@Baron105
descriptive
aa5f176
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9779c1a 
for more information, see https://pre-commit.ci
@Baron105
spacing
aa4d4e8
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
7bb663f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
52c2cb8 
for more information, see https://pre-commit.ci
@Baron105
removed
643958b
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
65f5851
@Baron105
Merge branch 'TheAlgorithms:master' into master
7f14ab9
@Baron105
changed name of file and added code improvements
c05ed7c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
886fb5d 
for more information, see https://pre-commit.ci
@Baron105
issues fixed due to pi
97b89cd
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
a1c783a
@Baron105
requested changes added
1c2b7b2
@Baron105
Merge branch 'TheAlgorithms:master' into master
5aa65b8
@Baron105
Merge branch 'TheAlgorithms:master' into master
59e9c01
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 15, 2023
cclauss
cclauss requested changes Oct 15, 2023
View reviewed changes
physics/archimedes_principle.py
Comment on lines 37 to 53
if volume < 0:
if volume <= 0:
raise ValueError("Impossible Object volume")
if gravity <= 0:
if gravity < 0:
Copy link
Member

@cclauss cclauss Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes. It is useful to be able to make theoretical calculations even if we are unable to reproduce those conditions.

Copy link
Contributor Author

@Baron105 Baron105 Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I remove the tests as well or just make the signs as they were before?

Copy link
Member

@cclauss cclauss Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need to follow the code. It is OK to have the tests but their output must pass.

Copy link
Contributor Author

@Baron105 Baron105 Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numerical tests are passing. Just added some more tests to see for when the inputs are invalid physically as in negative gravity, non positive volume and non positive density as they were already in the original code by the author.
These are also passing the tests.

Copy link
Contributor Author

@Baron105 Baron105 Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check @cclauss

Copy link
Member

@cclauss cclauss Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude! There are 215 pull requests open. Perhaps we will get to review this one.

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 15, 2023
@cclauss cclauss self-assigned this Oct 15, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 15, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 15, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 15, 2023
cclauss
cclauss approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@cclauss cclauss merged commit 7bdd1cd into TheAlgorithms:master Oct 15, 2023
@Baron105
Copy link
Contributor Author

Baron105 commented Oct 16, 2023

Great! Looks better now!

@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Baron105 @cclauss