Conversation
cclauss
reviewed
Oct 14, 2023
pyproject.toml
Outdated
| omit = [ | ||
| ".env/*", | ||
| "project_euler/*", | ||
| "scripts/*" |
Member
There was a problem hiding this comment.
Let's leave scripts in. I dislike not testing things.
Suggested change
| "scripts/*" |
I think the coverage report is way too long and users need to scroll across hundreds of lines (that no one reads) to find their failing pytests.
Would it be possible to put coverage in a separate GitHub Actions step so its output is not tagged directly on the end of pytest output?
Contributor
Author
There was a problem hiding this comment.
We could break up pytest into two separate workflows, one for tests and one for coverage.
Current:
- name: Run tests
# TODO: #8818 Re-enable quantum tests
run: pytest
--ignore=quantum/q_fourier_transform.py
--ignore=project_euler/
--ignore=scripts/validate_solutions.py
--cov-report=term-missing:skip-covered
--cov=. .Proposed:
- name: Run tests
# TODO: #8818 Re-enable quantum tests
run: pytest
--ignore=quantum/q_fourier_transform.py
--ignore=project_euler/
--ignore=scripts/validate_solutions.py
- name: Check test coverage
run: pytest
--cov-report=term-missing:skip-covered
--cov=.If this looks good to you, I can make this change in a separate PR.
project_euler/ and scripts/ from coverage reportsproject_euler/ from coverage reports
cclauss
approved these changes
Oct 15, 2023
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Our current
pytestcommand for our builds is the following:Since we're not testing files in the
project_euler/orscripts/directories, we should exclude them from our builds' coverage reports as well.project_euler/files in particular significantly clutter the reports.Checklist: