added mean absolute percentage error#10464
added mean absolute percentage error#10464tianyizheng02 merged 19 commits intoTheAlgorithms:masterfrom
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def mean_absolute_percentage_error(y_true: np.ndarray, y_pred: np.ndarray) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file machine_learning/loss_functions/mean_absolute_percentage_error.py, please provide doctest for the function mean_absolute_percentage_error
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
tianyizheng02
left a comment
There was a problem hiding this comment.
All loss function files were consolidated into machine_learning/loss_functions.py in #10737. Could you move your new code into that file?
|
tianyizheng02
left a comment
There was a problem hiding this comment.
Could you move your function to the bottom of the file, right below mean_squared_logarithmic_error?
Done as requested. |
Describe your change:
I added mean absolute percentage error to the loss function directory. I used matrix operations instead of for loops to enhance the performance of the algorithm. Looking forward to getting this pull request merged and also to acquire the hacktoberfest and hacktoberfest-accepted badge..
Checklist: