Added earliest deadline first scheduling algo #10431
Added earliest deadline first scheduling algo #10431Arunsiva003 wants to merge 19 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| current_time += 1 | ||
| else: | ||
| next_process = min( | ||
| available_processes, key=lambda x: x[2] |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
algorithms-keeper
bot
removed
the
require descriptive names
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
shirleydhaka
left a comment
shirleydhaka
left a comment
There was a problem hiding this comment.
We can make this code better it is already but one can sort it and make it more efficient
| @@ -0,0 +1,70 @@ | |||
| """ | |||
| Earliest Deadline First (EDF) Scheduling Algorithm | |||
|
|
|||
There was a problem hiding this comment.
The code currently sorts processes by deadline each time it needs to find the next process to execute
| Author: Arunkumar | ||
| Date: 14th October 2023 | ||
| """ | ||
|
|
| ) -> list[str]: | ||
| """ | ||
| Perform Earliest Deadline First (EDF) scheduling. | ||
|
|
There was a problem hiding this comment.
Input Validation: You may want to add some input validation to ensure that the input list of processes is well-formed. For example, you can check if the arrival time is less than or equal to the deadline for each process
There was a problem hiding this comment.
Once the code is merged, make a pull request on enhancement and do it! 👍
|
Please accept my reviews on this |
3 participants
Describe your change:
Checklist: