Added Lens formulae to the Physics repository#10187
Merged
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom Oct 26, 2023
san-jay-14:master
Merged
Added Lens formulae to the Physics repository#10187tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom san-jay-14:master
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom
san-jay-14:master
Conversation
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
physics/lens_formulae.py
Outdated
| return focal_length | ||
|
|
||
|
|
||
| def object_distance(focal_length_of_lens: float, image_distance_from_lens: float): |
There was a problem hiding this comment.
Please provide return type hint for the function: object_distance. If the function does not return a value, please provide the type hint as: def function() -> None:
Contributor
Author
|
I have Resolved all the issues commented in my code. Kindly go through my code and if any issues found comment them and I'll look into it and try to resolve as soon as possible. |
algorithms-keeper
bot
removed
the
require type hints
for more information, see https://pre-commit.ci
Contributor
Author
|
@cclauss Can you please take a look into my PR. |
tianyizheng02
requested changes
Oct 19, 2023
Contributor
tianyizheng02
left a comment
tianyizheng02
left a comment
There was a problem hiding this comment.
Please remove the indentation in the header docstring so that there's more space for text
tianyizheng02
approved these changes
Oct 26, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: