test_digital_image_processing -> test_local_binary_pattern replacing a large image with a smaller one#10161
Merged
cclauss merged 10 commits intoTheAlgorithms:masterfrom Oct 9, 2023
quant12345:tdip
Merged
test_digital_image_processing -> test_local_binary_pattern replacing a large image with a smaller one#10161cclauss merged 10 commits intoTheAlgorithms:masterfrom quant12345:tdip
cclauss merged 10 commits intoTheAlgorithms:masterfrom
quant12345:tdip
Conversation
algorithms-keeper
bot
added
enhancement
14 tasks
8 tasks
Member
|
It would be helpful if this pull request provided before and after times. |
cclauss
reviewed
Oct 9, 2023
|
|
||
| def test_local_binary_pattern(): | ||
| file_path = "digital_image_processing/image_data/lena.jpg" | ||
| file_path = "digital_image_processing/image_data/lena_small.jpg" |
Member
There was a problem hiding this comment.
Let's use https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
Suggested change
| file_path = "digital_image_processing/image_data/lena_small.jpg" | |
| from os import getenv # Speed up our Continuous Integration tests | |
| file_name = "lena_small.jpg" if getenv("CI") else "lena.jpg" | |
| file_path = f"digital_image_processing/image_data/{file_name}.jpg" |
Co-authored-by: Christian Clauss <cclauss@me.com>
for more information, see https://pre-commit.ci
tests fail, I'll try an empty commit
tianyizheng02
previously requested changes
Oct 9, 2023
|
|
||
| # Reading the image and converting it to grayscale. | ||
| file_name = "lena_small.jpg" if getenv("CI") else "lena.jpg" | ||
| file_path = f"digital_image_processing/image_data/{file_name}.jpg" |
Contributor
There was a problem hiding this comment.
Suggested change
| file_path = f"digital_image_processing/image_data/{file_name}.jpg" | |
| file_path = f"digital_image_processing/image_data/{file_name}" |
The build is failing because your filepath is "lena.jpg.jpg"
added clarifications
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
cclauss
approved these changes
Oct 9, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
Contributor
Author
|
@cclauss also added comments to the function itself: test_local_binary_pattern, indicating the pull request number and the values before and after. |
Contributor
|
Contributes to #9718 (adding for linking purposes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Replaced lena.jpg with lena_small.jpg to make tests faster.
pull request 10161 before:
file_path = "digital_image_processing/image_data/lena.jpg"after:
file_path = "digital_image_processing/image_data/lena_small.jpg"Checklist: