Add tests for infix_2_postfix() in infix_to_prefix_conversion.py#10095
Merged
cclauss merged 12 commits intoTheAlgorithms:masterfrom Oct 10, 2023
Merged
Add tests for infix_2_postfix() in infix_to_prefix_conversion.py#10095cclauss merged 12 commits intoTheAlgorithms:masterfrom
cclauss merged 12 commits intoTheAlgorithms:masterfrom
Conversation
…conversion.py Add doctests Add exceptions for expressions with invalid bracket positions Add type hints for functions Fix a bug on line 53 (57 in PR)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
14 tasks
Member
|
We need one pull request that ONLY adds doctests and does not modify the code. That will define the AS-IS behavior. We will merge this one first. The second will include those doctests modified to the proposed TO-BE code. |
Contributor
Author
|
Hi I see what you mean now, but the problem is the original code produces outputs with trailing spaces, so the "as-is" doctests cannot pass the current ruff check. That's why I have to change the code to change the output format with no trailing spaces. |
Member
|
OK... This is the correct tests for the current code. Please rebase the other pull request AFTER this one is merged. |
cclauss
approved these changes
Oct 10, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Related to #10063.
Checklist: