add : trapped water program under dynamic programming#10027
Merged
cclauss merged 29 commits intoTheAlgorithms:masterfrom Oct 7, 2023
kosuri-indu:add/trapped_water_problem
Merged
add : trapped water program under dynamic programming#10027cclauss merged 29 commits intoTheAlgorithms:masterfrom kosuri-indu:add/trapped_water_problem
cclauss merged 29 commits intoTheAlgorithms:masterfrom
kosuri-indu:add/trapped_water_problem
Conversation
kosuri-indu
changed the title
for more information, see https://pre-commit.ci
…-indu/Python into add/trapped_water_problem
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
…-indu/Python into add/trapped_water_problem
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
cclauss
reviewed
Oct 7, 2023
algorithms-keeper
bot
removed
the
require type hints
for more information, see https://pre-commit.ci
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
reviewed
Oct 7, 2023
cclauss
reviewed
Oct 7, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
Contributor
Author
|
@cclauss enumerate is showing an error |
…-indu/Python into add/trapped_water_problem
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 7, 2023
for more information, see https://pre-commit.ci
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
requested changes
Oct 7, 2023
algorithms-keeper
bot
added
awaiting changes
algorithms-keeper
bot
added
awaiting reviews
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 7, 2023
cclauss
reviewed
Oct 7, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
…-indu/Python into add/trapped_water_problem
cclauss
approved these changes
Oct 7, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
Contributor
Author
|
@cclauss Have a good day! |
algorithms-keeper
bot
removed
the
awaiting reviews
tianyizheng02
pushed a commit
to tianyizheng02/Python
that referenced
this pull request
Oct 8, 2023
…10027) * to add the trapped water program * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * to make changes for error : B006 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * to make changes for error : B006 * to make changes for error : B006 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * to make changes in doctest * to make changes in doctest * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dynamic_programming/trapped_water.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update dynamic_programming/trapped_water.py Co-authored-by: Christian Clauss <cclauss@me.com> * to make changes in parameters * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * to make changes in parameters * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dynamic_programming/trapped_water.py Co-authored-by: Christian Clauss <cclauss@me.com> * to make changes in parameters * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * for negative heights * Update dynamic_programming/trapped_water.py Co-authored-by: Christian Clauss <cclauss@me.com> * to remove falsy * Final edits * tuple[int, ...] --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR adds the trapped_water program under the dynamic programming folder
Fixes #10026
Checklist: