Resolve #7253: Clean up duplicate Java algorithm implementations#7255
Resolve #7253: Clean up duplicate Java algorithm implementations#7255krishnakamalbaishnab wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7255 +/- ##
============================================
- Coverage 79.38% 79.35% -0.03%
+ Complexity 7017 7009 -8
============================================
Files 785 781 -4
Lines 22982 22969 -13
Branches 4520 4518 -2
============================================
- Hits 18244 18228 -16
- Misses 4017 4018 +1
- Partials 721 723 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The modified files in this PR pass all tests locally and are already properly formatted according to the repository's clang-format style. |
|
@krishnakamalbaishnab The CI failures are not pre-existing. The current workflow failures are directly caused by changes in this PR. Specifically, the clang-format reformatting modified test files in a way that introduces a Checkstyle violation (e.g. an unused import in ValidParenthesesTest.java). As a result, the statement that all linter/build failures are unrelated to this cleanup is incorrect—the failures are reproducible in CI and stem from the changes introduced here. |
|
Thanks for the detailed feedback and review. This was a good learning experience for me, and I’ll make sure to validate lint, style, and coverage more carefully before future PRs. Appreciate you taking the time to review this. |
Summary of Changes
This PR resolves GitHub issue #7253: "Clean up duplicate Java algorithm implementations".
Changes include:
BoyerMooreMajorityVoteto distinguish from string search version; updated tests.GreedyCoinChange; updated tests.All tests for the modified packages pass; unrelated pre-existing test failures remain unchanged.
clang-format -i --style=file path/to/your/file.java