Skip to content

Fix ISO 10303-21 \S\ page encoding when followed by an apostrophe character #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thbeu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ISO 10303-21 \S\ page encoding when followed by an apostrophe character #1996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/cpp/web-ifc/parsing/IfcTokenChunk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ namespace webifc::parsing
// if its a quote, maybe its the end of the string
if (_fileStream->Get() == '\'')
{
// ISO 10303-21: \S\c encodes a single character c with high bit set.
// If c happens to be an apostrophe, it is NOT a string terminator.
size_t sz = temp.size();
if (sz >= 4 &&
temp[sz - 4] == '\\' &&
(temp[sz - 3] == 'S' || temp[sz - 3] == 's') &&
temp[sz - 2] == '\\')
{
_fileStream->Forward();
continue;
}
// if there's another quote behind it, its not
_fileStream->Forward();
if (_fileStream->Get() == '\'')
Expand Down