fix(SingleThreadedFragmentsModel)!: expose raw arg defaulting to false#209
Open
ShaMan123 wants to merge 1 commit into
Open
fix(SingleThreadedFragmentsModel)!: expose raw arg defaulting to false#209ShaMan123 wants to merge 1 commit into
raw arg defaulting to false#209ShaMan123 wants to merge 1 commit into
Conversation
Contributor
Author
|
updated description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SingleThreadedFragmentsModel#save and SingleThreadedFragmentsModel#edit returned a raw buffer. This does not align with the rest of the API, which defaults to
false.I have exposed
rawas a last arg defaulting to false.Should we add a comment that runtime editing should use
rawin order to avoid deflating/inflating for performance reasons?fixes #186 (comment)
Additional context
Before this fix
After this fix
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).