fix: brittle AwaitableCallbackExtensions test#1007
Merged
Conversation
vbreuss
added
the
coverage
There was a problem hiding this comment.
Pull request overview
This PR makes the AwaitableCallbackExtensions cancellation test less timing-dependent by removing delayed background event generation and cancelling after a deterministic number of buffered events.
Changes:
- Adds
System.Collections.GenericforList<T>. - Pre-creates directory events synchronously before enumerating.
- Cancels the token after collecting six async enumerable results and asserts the final count.
|
|
This is addressed in release v6.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR makes the
AwaitableCallbackExtensionscancellation test less timing-dependent by removing delayed background event generation and cancelling after a deterministic number of buffered events.Changes:
System.Collections.GenericforList<T>.