Skip to content

Migration to NUnit#348

Merged
Roemer merged 43 commits intomasterfrom
nunit
Dec 23, 2015
Merged

Migration to NUnit#348
Roemer merged 43 commits intomasterfrom
nunit

Conversation

@Roemer
Copy link
Copy Markdown
Collaborator

@Roemer Roemer commented Dec 22, 2015

There we go. The migration to NUnit is done. CI (AppVeyor) is up and running.
I think what should be reviewed before merging is the stuff which is not in and test-assembly.
I'll wait a few days max until I merge this to master if I don't get any feedback.

Roemer and others added 30 commits December 18, 2015 23:49
…ince it's an interface, Added default values for german
Updated automation element x test to nunit and added frameworkid as a
property of the WhiteUITestBase.
- Fixed various formatting issues with test's name and test fixture's
name
- Used visual studios ctrl k,d to format document
- Removed unused setter on FrameworkId
Forgot to include change to csproj for file name change
Merged AutomationElementXTest.cs to use nunit
@Roemer
Copy link
Copy Markdown
Collaborator Author

Roemer commented Dec 22, 2015

You might need to look at the patch file (https://github.com/TestStack/White/pull/348.patch) because it's too big.

You can also use the javascript $('.data.blob-wrapper').hide() to collapse all entries so you can at least open / close those files which are shown.

You can also create an "All-in-One" .diff file with the git command git diff master..nunit >e:\test.diff That's the file I will review again for myself.

@Roemer Roemer mentioned this pull request Dec 22, 2015
@ilya-murzinov
Copy link
Copy Markdown
Contributor

I don't have any time to review this, but I want to thank you all for supporting the project! 👍

@Roemer
Copy link
Copy Markdown
Collaborator Author

Roemer commented Dec 22, 2015

Here's a quick summary of non-unittest changes:

  • Cleaned some unused files
  • Changed nuget to the newer automatic package restore
  • AppVeyor integration
  • Renamed file CoreConfiguration.cs to ICoreConfiguration.cs
  • Changed interface UIItemIdConfiguration to IUIItemIdConfiguration
  • Added some german default values to UIItemIdAppXmlConfiguration.cs
  • Added 3 new Values to IUIItemIdConfiguration
    • BrowseText
    • OpenFileDialogTitle
    • PropertyGridMiscText

If we're good with those changes, I can merge the pull request.

@maxinfet maxinfet closed this Dec 23, 2015
@maxinfet maxinfet deleted the nunit branch December 23, 2015 04:00
@Roemer
Copy link
Copy Markdown
Collaborator Author

Roemer commented Dec 23, 2015

Why did you delete it?

@maxinfet
Copy link
Copy Markdown
Contributor

I didnt meen to close and delete this. Sorry. I was just reviewing this I think my friends cat got to it... Lessons in locking your comp...

@maxinfet maxinfet restored the nunit branch December 23, 2015 06:18
@maxinfet maxinfet reopened this Dec 23, 2015
@Roemer
Copy link
Copy Markdown
Collaborator Author

Roemer commented Dec 23, 2015

Thought so ;-) I' ll merge in a few hours.

Roemer added a commit that referenced this pull request Dec 23, 2015
@Roemer Roemer merged commit 36c4cbd into master Dec 23, 2015
@Roemer Roemer deleted the nunit branch December 23, 2015 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants