fix(core.gradle-plugin): 修复AGP 3.1.0及更高版本的兼容性#765
Merged
Conversation
shifujun
force-pushed
the
757
branch
2 times, most recently
from
a755eda to
c1e7eaa
Compare
主要以黑盒自动化测试驱动本次代码修复。详见： projects/test/gradle-plugin-agp-compat-test/README.md AGPCompatImpl更理想的方式是按AGP版本拆分成多个文件， 但考虑到AGP版本号获取的是一个字符串，而且业务有可能使用一些beta等版本的AGP， 版本号匹配风险比较大。所以目前实现方式是try-catch的方式。 移除pom中对com.android.tools.build依赖的声明。 这个声明会把AGP依赖带入构建项目中，可能会导致项目声明的AGP版本不生效。 fix Tencent#757
shifujun
force-pushed
the
757
branch
2 times, most recently
from
f5c42c8 to
f821026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
主要以黑盒自动化测试驱动本次代码修复。详见：
projects/test/gradle-plugin-agp-compat-test/README.md
AGPCompatImpl更理想的方式是按AGP版本拆分成多个文件，
但考虑到AGP版本号获取的是一个字符串，而且业务有可能使用一些beta等版本的AGP，
版本号匹配风险比较大。所以目前实现方式是try-catch的方式。
移除pom中对com.android.tools.build依赖的声明。
这个声明会把AGP依赖带入构建项目中，可能会导致项目声明的AGP版本不生效。
fix #757