Skip to content

Comments

refactor: Function to get execution status stats#95

Open
yuechao-qin wants to merge 1 commit intomasterfrom
ycq/function_get_execution_status_stats
Open

refactor: Function to get execution status stats#95
yuechao-qin wants to merge 1 commit intomasterfrom
ycq/function_get_execution_status_stats

Conversation

@yuechao-qin
Copy link
Collaborator

@yuechao-qin yuechao-qin commented Feb 17, 2026

TL;DR

Refactored execution status stats calculation and added comprehensive tests for the pipeline runs API service.

What changed?

  • Extracted the execution status stats formatting logic into a new method _get_execution_status_stats
  • Added extensive test coverage for the PipelineRunsApiService_Sql class

How to test?

Run the new test cases in tests/test_api_server_sql.py:

pytest tests/test_api_server_sql.py

Why make this change?

Created this function to be used in upstream PRs for Pipeline Run API (list and get)

@yuechao-qin yuechao-qin marked this pull request as ready for review February 17, 2026 17:28
@yuechao-qin yuechao-qin requested a review from Ark-kun as a code owner February 17, 2026 17:28
@yuechao-qin yuechao-qin changed the base branch from ycq/count_execution_summary to graphite-base/95 February 17, 2026 22:03
@yuechao-qin yuechao-qin force-pushed the ycq/function_get_execution_status_stats branch from 1229fcb to f086771 Compare February 18, 2026 02:26
@yuechao-qin yuechao-qin changed the base branch from graphite-base/95 to ycq/count_execution_summary February 18, 2026 02:26
@yuechao-qin yuechao-qin changed the base branch from ycq/count_execution_summary to graphite-base/95 February 20, 2026 04:27
@yuechao-qin yuechao-qin force-pushed the ycq/function_get_execution_status_stats branch from f086771 to e2e05ef Compare February 20, 2026 04:27
@yuechao-qin yuechao-qin changed the base branch from graphite-base/95 to ycq/count_execution_summary February 20, 2026 04:27
@yuechao-qin yuechao-qin changed the base branch from ycq/count_execution_summary to graphite-base/95 February 21, 2026 02:40
@yuechao-qin yuechao-qin force-pushed the ycq/function_get_execution_status_stats branch from e2e05ef to e382bc8 Compare February 21, 2026 02:40
@graphite-app graphite-app bot changed the base branch from graphite-base/95 to master February 21, 2026 02:40
@yuechao-qin yuechao-qin force-pushed the ycq/function_get_execution_status_stats branch from e382bc8 to 5ae141c Compare February 21, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant