CrowdTangle Integration#325
Merged
Merged
Conversation
…angle calls are managed by the pull bot.
karpawich
approved these changes
Jun 26, 2020
Contributor
|
Note: We should research some checkstyle/formatting tool for JS/HTML code. Its not useful to see changes such as new lines/deleted lines that happen naturally while making actual code changes. It would be nice to have a checkstyle/formatting tool so that new changes only reflect the actual code changes and not the line additions/subtractions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes with the integration of the crowdtangle API into the aggie platform. However, not everything is finished. We want to add several fields into the metadata field of each report. See lib/fetching/content-services/crowd-tangle-content-service.js to see the brunt of the added code. The included json file (config/crowdtangle_list.json) is to store crowdtangle lists and their corresponding account ids. I also removed prettyjson from crowd-tangle-content-service.js and winston slack report from master-logger.js because they didn't work with a clean install of the branch. This may cause problems later.