Skip to content

Add VCS-based sidebar label coloring#217

Merged
FichteFoll merged 6 commits into
SublimeText:mainfrom
alecmev:vcs
Aug 24, 2024
Merged

Add VCS-based sidebar label coloring#217
FichteFoll merged 6 commits into
SublimeText:mainfrom
alecmev:vcs

Conversation

@alecmev

@alecmev alecmev commented May 21, 2019

Copy link
Copy Markdown
Collaborator

Essentially a copy-paste from Toxin, thanks @p3lim! One divination is that I chose to decolor the VCS badges, instead of outright hiding them, since they help distinguish created/modified from staged. Another is the italic for ignored files, which I wouldn't mind dropping, but it's somewhat useful.

Didn't know what colors to choose, so just looked at VS Code's Base16 Themes.

This is opt-in, spacegray_sidebar_vcs_label setting enables the whole thing, spacegray_sidebar_vcs_expanded also applies the coloring to expanded folders. The latter one is the same setting name as in Toxin, for potential interop.

Added variables introduced in 3179, because why not. Opted not to indent the rules as to not ruin the diff for the main feature and to not pollute the blame trail. base prefix because reasons.

Also piggybacked in a fix for #188, since the original PR has died a slow and painful death.

Fixes #214
Fixes #188

image

@alecmev alecmev mentioned this pull request May 21, 2019
@alecmev alecmev force-pushed the vcs branch 3 times, most recently from 0be2610 to ec8654f Compare May 22, 2019 15:41
@marcofugaro

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! Will test this locally and review the changes!

@alecmev

alecmev commented May 26, 2019

Copy link
Copy Markdown
Collaborator Author

@marcofugaro Took a closer look at the other themes, besides Eighties, and yeah, those needed tuning, especially Light. Also got rid of the selected effect, doesn't look good, and isn't really necessary.

@alecmev

alecmev commented Aug 27, 2019

Copy link
Copy Markdown
Collaborator Author

Rebased to fix a conflict in readme.

@alecmev

alecmev commented May 20, 2020

Copy link
Copy Markdown
Collaborator Author

@marcofugaro

@alecmev

alecmev commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator Author

@kkga @marcofugaro Hi! I'm willing to adopt this theme. Could fork, but I don't intend to change much, just modernize.

@kkga

kkga commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator

@alecmev hey! Thanks for your interest. Do you want to move this repo to community packages org?

@alecmev

alecmev commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator Author

@kkga Yeah! I haven't coordinated with them yet though. I think you need to be a part of an organization to be able to transfer to it. You can transfer to me, and I can take care of the rest, what do you prefer?

@FichteFoll

FichteFoll commented Aug 11, 2022

Copy link
Copy Markdown
Member

Hello, I am your person of contact for moving packages to the SublimeText org.

Your assessments have been correct so far. The person moving the repo needs to be a part of the org and since @alecmev volunteered to take maintainership, I invited him. I suggest the following procedure

  1. @kkga transfers the repo to @alecmev
  2. @alecmev transfers the repo to the org
  3. @alecmev updates the reference to the package in the package_control_channel via a PR
  4. In the meantime, I configure the permissions for the moved repository

From then on, you are free to do whatever you would if the package hadn't been moved, i.e. push new updates by creating a new tag.

@kkga

kkga commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator

@alecmev any idea what this means?

image

@FichteFoll

FichteFoll commented Aug 11, 2022

Copy link
Copy Markdown
Member

Ah, I suspect that is because of an already existing fork. I didn't think of that.

You may also transfer the repo to me and I will take care of transfering it to the org.

@alecmev

alecmev commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator Author

Ah, I suspect that is because of an already existing fork. I didn't think of that.

Indeed! I renamed the fork to spacegray-fork ahead of it, but that didn't help.

You may also transfer the repo to me and I will take care of transfering it to the org.

I already submitted a "detach a fork" request to GitHub, but this is faster, thanks for offering! @kkga Can you transfer to @FichteFoll instead, please?

@alecmev

alecmev commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator Author

@kkga The fork has been detached, just in case, so you can transfer to me too 😉

@kkga

kkga commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator

The transferto @FichteFoll is already in progress. Just waiting for them to accept I think.

@FichteFoll

Copy link
Copy Markdown
Member

Indeed, all done on my part.

@kkga

kkga commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator

Great, thanks all!

@alecmev

alecmev commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator Author

Thank you! 👍

alecmev added a commit to alecmev/package_control_channel that referenced this pull request Aug 11, 2022
braver pushed a commit to sublimehq/package_control_channel that referenced this pull request Aug 11, 2022
@jakitliang

jakitliang commented Feb 6, 2024

Copy link
Copy Markdown

Is there any progress? @alecmev

@alecmev

alecmev commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator Author

Didn't realize there was demand, will try to clean up and release soon. This isn't ready as-is yet, unfortunately, as I've noticed some inconsistencies between dark/light in personal use.

@alecmev alecmev mentioned this pull request Jul 31, 2024

@FichteFoll FichteFoll left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a brief look at the contents here (as a result of #221) and have a small question.

Comment thread Spacegray.sublime-theme
@alecmev alecmev changed the base branch from main to tmp August 18, 2024 12:01
@alecmev alecmev changed the base branch from tmp to main August 18, 2024 12:02
@FichteFoll FichteFoll merged commit 2be59dc into SublimeText:main Aug 24, 2024
@FichteFoll

FichteFoll commented Aug 24, 2024

Copy link
Copy Markdown
Member

Thanks for sticking to it. I have released 1.4.0 with these changes.

Feel free to do changes on your own in the future (via pull requests or directly).

@alecmev alecmev deleted the vcs branch August 24, 2024 10:53
@alecmev

alecmev commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git + sidebar + gutter Open files close icon margin issue after setting 'spacegray_fileicons:true'

5 participants