Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Add an explicit dependency on libboost-filesystem.#98

Merged
igorpeshansky merged 1 commit intomasterfrom
igorp-health-check-dependencies
Mar 28, 2018
Merged

Add an explicit dependency on libboost-filesystem.#98
igorpeshansky merged 1 commit intomasterfrom
igorp-health-check-dependencies

Conversation

@igorpeshansky
Copy link
Copy Markdown
Contributor

@igorpeshansky igorpeshansky commented Mar 28, 2018

Needed for code introduced in #85.

Copy link
Copy Markdown
Contributor

@bmoyles0117 bmoyles0117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread README.md

$ sudo apt-get install libyajl2 libboost-program-options1.55.0 \
libboost-system1.55.0 libboost-thread1.55.0
$ sudo apt-get install libyajl2 libboost-filesystem1.55.0 \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the health check stuff I suppose?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the health check introduced in #85 actually used non-inlined functions from libboost_filesystem, so it linked the library.

Copy link
Copy Markdown
Contributor

@dhrupadb dhrupadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@igorpeshansky igorpeshansky merged commit 58789fd into master Mar 28, 2018
@igorpeshansky igorpeshansky deleted the igorp-health-check-dependencies branch March 28, 2018 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants