This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Add a LookupMetadata function to the metadata store.#90
Merged
igorpeshansky merged 2 commits intomasterfrom Mar 27, 2018
Merged
Add a LookupMetadata function to the metadata store.#90igorpeshansky merged 2 commits intomasterfrom
igorpeshansky merged 2 commits intomasterfrom
Conversation
supriyagarg
reviewed
Mar 27, 2018
| std::lock_guard<std::mutex> lock(store_.resource_mu_); | ||
| const auto result = store_.resource_map_.find(id); | ||
| if (result == store_.resource_map_.end()) { | ||
| if (result != store_.resource_map_.end()) { |
Contributor
There was a problem hiding this comment.
The overall change looks good.
Not sure about this commit though - why the need to reverse the if/else?
Positive comparisons are easier to read (harder to misread) anyway.
Contributor
Author
There was a problem hiding this comment.
This was just to make the change from if/else to try/catch in the next commit easier to see (otherwise it might get lost in the delete/add of the move).
Contributor
There was a problem hiding this comment.
thanks. I was reading the commits the wrong way around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.