This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Remove pod startTime, as it is causing exceptions and is not used.#81
Merged
bmoyles0117 merged 3 commits intomasterfrom Mar 15, 2018
Merged
Remove pod startTime, as it is causing exceptions and is not used.#81bmoyles0117 merged 3 commits intomasterfrom
bmoyles0117 merged 3 commits intomasterfrom
Conversation
igorpeshansky
suggested changes
Mar 15, 2018
| @@ -206,8 +206,6 @@ MetadataUpdater::ResourceMetadata KubernetesReader::GetPodMetadata( | |||
| Timestamp created_at = time::rfc3339::FromString(created_str); | |||
|
|
|||
| const json::Object* status = pod->Get<json::Object>("status"); | |||
Contributor
There was a problem hiding this comment.
I believe this is now unused as well, right?
igorpeshansky
suggested changes
Mar 15, 2018
| << " not the same as agent node " << node_name; | ||
| } | ||
|
|
||
| const json::Object* status = pod->Get<json::Object>("status"); |
Contributor
There was a problem hiding this comment.
This looks like the wrong one... Does the code still build?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.