Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Guard access to containerStatuses by checking if the key exists.#79

Merged
bmoyles0117 merged 3 commits intomasterfrom
bmoyles0117-fix-missing-container-statuses
Mar 15, 2018
Merged

Guard access to containerStatuses by checking if the key exists.#79
bmoyles0117 merged 3 commits intomasterfrom
bmoyles0117-fix-missing-container-statuses

Conversation

@bmoyles0117
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

Comment thread src/kubernetes.cc Outdated
<< pod_id << "(" << pod_name << ")";
}
} else {
LOG(ERROR) << "Container statuses do not exist in status for pod "
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOG(INFO).

Copy link
Copy Markdown
Contributor

@supriyagarg supriyagarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@bmoyles0117 bmoyles0117 merged commit 826f56f into master Mar 15, 2018
@bmoyles0117 bmoyles0117 deleted the bmoyles0117-fix-missing-container-statuses branch March 15, 2018 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants