This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Add the full instance monitored resource to associations#52
Merged
igorpeshansky merged 1 commit intomasterfrom Feb 7, 2018
Merged
Add the full instance monitored resource to associations#52igorpeshansky merged 1 commit intomasterfrom
igorpeshansky merged 1 commit intomasterfrom
Conversation
…ructureInstance". Replaces "providerPlatform".
Contributor
Author
|
@Georgehe4 and @shoucongc FYI. |
bmoyles0117
reviewed
Feb 2, 2018
| : config_(config), environment_(config) {} | ||
|
|
||
| json::value KubernetesReader::InstanceResource() const { | ||
| const std::string resource_type = "gce_instance"; // TODO: detect other resources. |
Contributor
There was a problem hiding this comment.
Only minor comment, does the comment need to wrap lines?
Contributor
Author
There was a problem hiding this comment.
Technically it does, but it's a TODO that will be removed, and there are other lines in this file that are over 80 characters, so maybe overkill? TODOs that aren't line comments tend to get dissociated from the appropriate lines over time.
igorpeshansky
added a commit
that referenced
this pull request
Feb 7, 2018
As "infrastructureResource". Replaces "providerPlatform".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
"infrastructureResource". Replaces"providerPlatform".