Add test for GetPodAndContainerMetadata#130
Conversation
| Configuration config(std::stringstream( | ||
| "KubernetesClusterName: TestClusterName\n" | ||
| "KubernetesClusterLocation: TestClusterLocation\n" | ||
| "MetadataApiResourceTypePerarator: \".\"\n" |
There was a problem hiding this comment.
Please fix. TypeSeparator?
| })}, | ||
| }); | ||
|
|
||
| auto metadatas = GetPodAndContainerMetadata( |
There was a problem hiding this comment.
why not m like in other places.
If you want plural, then metadata_list or something is better.
There was a problem hiding this comment.
changed to metadata_list
There was a problem hiding this comment.
Frankly, I prefer m for brevity. Any reason to not go with that? As @supriyagarg mentioned, this is a convention in other tests.
There was a problem hiding this comment.
I guess I have a strong aversion to single-letter variable names. Changed.
| EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), | ||
| metadatas[1].metadata().created_at); | ||
| EXPECT_EQ(Timestamp(), metadatas[1].metadata().collected_at); | ||
| json::value metadata1 = json::object({ |
There was a problem hiding this comment.
metadata1 -> container1
| EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), | ||
| metadatas[2].metadata().created_at); | ||
| EXPECT_EQ(Timestamp(), metadatas[2].metadata().collected_at); | ||
| json::value metadata2 = json::object({ |
There was a problem hiding this comment.
metadata2 -> container2
| "KubernetesClusterName: TestClusterName\n" | ||
| "KubernetesClusterLocation: TestClusterLocation\n" | ||
| "MetadataApiResourceTypePerarator: \",\"\n" | ||
| "MetadataApiResourceTypeSeperator: \",\"\n" |
There was a problem hiding this comment.
Make that MetadataApiResourceTypeSeparator (here and below).
Sigh, the config revamp in #127 would allow catching invalid config options.
There was a problem hiding this comment.
This still needs to be fixed.
There was a problem hiding this comment.
Fixed, sorry about that
| EXPECT_EQ("gke_container.TestNamespace.TestPodUid.TestContainerName0", | ||
| metadata_list[0].ids()[0]); | ||
| EXPECT_EQ("gke_container.TestNamespace.TestPodName.TestContainerName0", | ||
| metadata_list[0].ids()[1]); |
There was a problem hiding this comment.
EXPECT_EQ(std::vector<std::string>{
"gke_container.TestNamespace.TestPodUid.TestContainerName0",
"gke_container.TestNamespace.TestPodName.TestContainerName0",
}, metadata_list[0].ids());| EXPECT_EQ("k8s_container.TestPodUid.TestContainerName0", | ||
| metadata_list[1].ids()[0]); | ||
| EXPECT_EQ("k8s_container.TestNamespace.TestPodName.TestContainerName0", | ||
| metadata_list[1].ids()[1]); |
There was a problem hiding this comment.
EXPECT_EQ(std::vector<std::string>{
"k8s_container.TestPodUid.TestContainerName0",
"k8s_container.TestNamespace.TestPodName.TestContainerName0",
}, metadata_list[1].ids());| EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), | ||
| metadata_list[2].metadata().created_at); | ||
| EXPECT_EQ(Timestamp(), metadata_list[2].metadata().collected_at); | ||
| json::value container2 = json::object({ |
There was a problem hiding this comment.
Should this not be pod metadata?
There was a problem hiding this comment.
I actually meant that this looks like container metadata (with the "metadata", "spec", and "status" fields). Should this not be pod metadata (with one "api" field)?
There was a problem hiding this comment.
Hmm, well reading the code, it does seem to me that a pod should be played at the end of the metadata list. Truthfully, I had a hard time following all the code paths closely, so its difficult for me to evaluate whether this is an actual bug.
There was a problem hiding this comment.
Oh, silly me. This is pod metadata. I miscounted the nesting depth. Never mind.
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
There's one more comment about the typo in the option name...
| EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), | ||
| metadata_list[2].metadata().created_at); | ||
| EXPECT_EQ(Timestamp(), metadata_list[2].metadata().collected_at); | ||
| json::value container2 = json::object({ |
There was a problem hiding this comment.
I actually meant that this looks like container metadata (with the "metadata", "spec", and "status" fields). Should this not be pod metadata (with one "api" field)?
igorpeshansky
left a comment
igorpeshansky
left a comment
There was a problem hiding this comment.
One remaining rename that still needs to happen.
| "KubernetesClusterName: TestClusterName\n" | ||
| "KubernetesClusterLocation: TestClusterLocation\n" | ||
| "MetadataApiResourceTypePerarator: \",\"\n" | ||
| "MetadataApiResourceTypeSeperator: \",\"\n" |
There was a problem hiding this comment.
This still needs to be fixed.
| EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), | ||
| metadata_list[2].metadata().created_at); | ||
| EXPECT_EQ(Timestamp(), metadata_list[2].metadata().collected_at); | ||
| json::value container2 = json::object({ |
There was a problem hiding this comment.
Oh, silly me. This is pod metadata. I miscounted the nesting depth. Never mind.
| is_deleted); | ||
| } | ||
|
|
||
| std::vector<MetadataUpdater::ResourceMetadata> GetPodAndContainerMetadata( |
There was a problem hiding this comment.
Any reason these accessors are not static?
3 participants
No description provided.