This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Merged
Conversation
igorpeshansky
changed the title
igorpeshansky
suggested changes
Apr 2, 2018
| })->As<json::Object>(), | ||
| json::string("TestAssociations"), | ||
| Timestamp(), | ||
| false); |
Contributor
There was a problem hiding this comment.
Let's make this /*is_deleted=*/false.
| })->As<json::Object>(), | ||
| json::object({{"name", json::string("TestSpecName")}})->As<json::Object>(), | ||
| json::object({ | ||
| {"containerID", json::string("docker://TestContainerID")} |
Contributor
There was a problem hiding this comment.
Trailing comma, please.
| {"uid", json::string("TestUid")}, | ||
| {"creationTimestamp", json::string("2018-03-03T01:23:45.678901234Z")}, | ||
| {"labels", json::object({{"label", json::string("TestLabel")}})}, | ||
| })} |
Contributor
There was a problem hiding this comment.
Trailing comma, please.
| {"raw", json::object({ | ||
| {"containerID", json::string("docker://TestContainerID")}, | ||
| })}, | ||
| {"version", json::string("1.6")} |
Contributor
There was a problem hiding this comment.
Trailing comma, please.
| EXPECT_EQ(std::vector<std::string>({ | ||
| "k8s_container.TestUid.TestSpecName", | ||
| "k8s_container.TestNamespace.TestName.TestSpecName", | ||
| "k8s_container.TestContainerID"}), m.ids()); |
Contributor
There was a problem hiding this comment.
Let's break before the } and add a trailing comma.
Contributor
Author
There was a problem hiding this comment.
Much better, updated.
igorpeshansky
suggested changes
Apr 2, 2018
| KubernetesReader reader(config, nullptr); // Don't need HealthChecker. | ||
| const auto m = GetContainerMetadata( | ||
| reader, | ||
| json::object({ |
Contributor
There was a problem hiding this comment.
I would factor this call out to a pod local variable...
igorpeshansky
suggested changes
Apr 2, 2018
| const auto m = GetContainerMetadata( | ||
| reader, | ||
| pod->As<json::Object>(), | ||
| json::object({{"name", json::string("TestSpecName")}})->As<json::Object>(), |
Contributor
There was a problem hiding this comment.
These too, as spec and status?
igorpeshansky
suggested changes
Apr 2, 2018
| }); | ||
| json::value spec = json::object({{"name", json::string("TestSpecName")}}); | ||
| json::value status = json::object({{ | ||
| "containerID", json::string("docker://TestContainerID")}}); |
Contributor
There was a problem hiding this comment.
When split over multiple lines, let's use the following formatting:
json::value status = json::object({
{"containerID", json::string("docker://TestContainerID")},
});
igorpeshansky
suggested changes
Apr 4, 2018
| }); | ||
| json::value spec = json::object({{"name", json::string("TestSpecName")}}); | ||
| json::value status = json::object({ | ||
| {"containerID", json::string("docker://TestContainerID")} |
Contributor
There was a problem hiding this comment.
Trailing comma, please.
ACEmilG
force-pushed
the
ACEmilG-GetContainerMetadata-test
branch
from
b71d992 to
590cd89
Compare
Contributor
Author
|
Rebased against master |
ACEmilG
force-pushed
the
ACEmilG-GetContainerMetadata-test
branch
from
590cd89 to
418ec6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.