This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Merged
Conversation
igorpeshansky
changed the title
igorpeshansky
suggested changes
Apr 2, 2018
| EXPECT_EQ(time::rfc3339::FromString("2018-03-03T01:23:45.678901234Z"), | ||
| m.metadata().created_at); | ||
| EXPECT_EQ(Timestamp(), m.metadata().collected_at); | ||
| EXPECT_EQ(false, m.metadata().ignore); |
Contributor
There was a problem hiding this comment.
EXPECT_FALSE(m.metadata().ignore);
| {"namespace_name", "TestNamespace"}, | ||
| }), m.resource()); | ||
| EXPECT_EQ("TestVersion", m.metadata().version); | ||
| EXPECT_EQ(false, m.metadata().is_deleted); |
Contributor
There was a problem hiding this comment.
EXPECT_FALSE(m.metadata().is_deleted);
supriyagarg
approved these changes
Apr 2, 2018
Contributor
supriyagarg
left a comment
supriyagarg
left a comment
There was a problem hiding this comment.
Very minor comment. Otherwise LGTM
| const KubernetesReader& reader, const json::Object* pod, | ||
| json::value associations, Timestamp collected_at, bool is_deleted) const | ||
| throw(json::Exception) { | ||
| return reader.GetPodMetadata(pod, std::move(associations), collected_at, is_deleted); |
Contributor
Author
There was a problem hiding this comment.
Sorry, missed this one! Fixed
igorpeshansky
suggested changes
Apr 2, 2018
| "KubernetesClusterLocation: TestClusterLocation\n" | ||
| "MetadataApiResourceTypePerarator: \",\"\n" | ||
| "MetadataIngestionRawContentVersion: TestVersion\n" | ||
| )); |
| {"name", json::string("TestName")}, | ||
| {"uid", json::string("TestUid")}, | ||
| {"creationTimestamp", json::string("2018-03-03T01:23:45.678901234Z")}, | ||
| })} |
Contributor
There was a problem hiding this comment.
Trailing comma, please.
| json::string("2018-03-03T01:23:45.678901234Z")}, | ||
| {"name", json::string("TestName")}, | ||
| {"namespace", json::string("TestNamespace")}, | ||
| {"uid", json::string("TestUid")} |
Contributor
There was a problem hiding this comment.
Trailing comma, please.
igorpeshansky
suggested changes
Apr 2, 2018
| {"uid", json::string("TestUid")}, | ||
| {"creationTimestamp", json::string("2018-03-03T01:23:45.678901234Z")}, | ||
| })}, | ||
| })->As<json::Object>(), |
Contributor
There was a problem hiding this comment.
These ->As<json::Object>() and ->ToString() calls get lost at the end of inline JSON values... That's why I'm suggesting factoring them out into locals, to make this more readable... WDYT?
Contributor
Author
There was a problem hiding this comment.
I agree, I'll go forward and do this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.