Add WebDAV methods to valid request_methods.#78
Merged
Conversation
Contributor
|
Yes, I am in favor of dropping these validations. They don't really improve the validity of anything anyway. |
Contributor
Author
|
PR has been updated to instead just limit the request_method to 50 characters (and allow nil). That way we'll prevent it from taking too much junk without restricting odd request methods. |
RISCfuture
added a commit
that referenced
this pull request
May 8, 2013
Add WebDAV methods to valid request_methods.
mexisme
pushed a commit
to fluxfederation/SquareSquash-web
that referenced
this pull request
Apr 22, 2015
Add WebDAV methods to valid request_methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be a sign that request_method shouldn't have any validation on it? I can only imagine there are other HTTP-accessible services with their own made-up verbs?