Add VERSIONS WOOHOO#9
Conversation
|
Warning Review limit reached
More reviews will be available in 36 minutes and 36 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR extends the Minecraft-Script compiler to support multiple Minecraft versions with version-specific text component serialization. It adds version-stem-based profile resolution for range versions (e.g., ChangesMulti-version profiles with configurable text component serialization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
minecraft_script/versions/1.21.9-10.json (1)
4-4: Legacypack.mcmetatemplate won’t be emitted for range-format profiles.
minecraft_script/version_config.pyselects the pack metadata template fromorchestration["pack"]["format"].style: when it is"range",render_pack_mcmeta()renderspack.mcmeta.range; otherwise it renders the legacypack.mcmeta. The existing version-profile test expects range output (min_format/max_format == [88, 0]and nopack_format), matchingpack.mcmeta.range, so the hardcodedsupported_formats: [81, 81]inminecraft_script/versions/1.21.9-10.jsonis not functionally used for the range case.Optional: remove or align the unused legacy
pack.mcmetablocks across the range profiles to avoid confusion.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@minecraft_script/versions/1.21.9-10.json` at line 4, The legacy pack.mcmeta block in the JSON is misleading for profiles using range-style pack metadata; update the range-format profiles so they don't include a hardcoded legacy "pack.mcmeta" template (or align it with the range semantics). Locate where orchestration["pack"]["format"].style is expected to be "range" and where render_pack_mcmeta() selects pack.mcmeta.range vs pack.mcmeta, then remove or replace the legacy "pack.mcmeta" entry in versions like the 1.21.9-10 profile so the file either omits the legacy template or matches the range-format output (no pack_format and using min_format/max_format) to avoid confusion with pack.mcmeta.range.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@minecraft_script/versions/1.21.9-10.json`:
- Line 4: The legacy pack.mcmeta block in the JSON is misleading for profiles
using range-style pack metadata; update the range-format profiles so they don't
include a hardcoded legacy "pack.mcmeta" template (or align it with the range
semantics). Locate where orchestration["pack"]["format"].style is expected to be
"range" and where render_pack_mcmeta() selects pack.mcmeta.range vs pack.mcmeta,
then remove or replace the legacy "pack.mcmeta" entry in versions like the
1.21.9-10 profile so the file either omits the legacy template or matches the
range-format output (no pack_format and using min_format/max_format) to avoid
confusion with pack.mcmeta.range.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a47e1ad9-e76b-415c-b9ac-f1f14c287a31
📒 Files selected for processing (13)
minecraft_script/compiler/builtin_functions.pyminecraft_script/compiler/text_component_builtins.pyminecraft_script/text_components.pyminecraft_script/version_config.pyminecraft_script/versions/1.21.11.jsonminecraft_script/versions/1.21.4.jsonminecraft_script/versions/1.21.5.jsonminecraft_script/versions/1.21.6.jsonminecraft_script/versions/1.21.7-8.jsonminecraft_script/versions/1.21.9-10.jsonminecraft_script/versions/26.1.jsonminecraft_script/versions/index.jsontests/test_version_profiles.py
- Replaced the version expansion logic with a new method to load version profiles from an index file, improving maintainability. - Updated the `pack.mcmeta` template format to use `min_format` and `max_format` instead of `pack_format` and `supported_formats` for better compatibility with version ranges. - Added new profiles to the version index for better version management and support in the Minecraft-Script environment.
|
@cursor review |
Summary by CodeRabbit
Release Notes
New Features
Improvements
Tests