Merged
Conversation
…nsupported FLAC filter Three related fixes for issue #389, where custom notification sounds silently fell back to the built-in default on Windows. Root cause: Rodio 0.22 uses Symphonia for decoding. The compiled Symphonia crates only included PCM WAV support. ADPCM-encoded WAV (the default output of Windows Sound Recorder) failed to decode silently, and FLAC — offered in the file picker — was never decodable. Failures were never surfaced to the user; they would see their filename in settings but hear the wrong sound. - Add symphonia-codec-adpcm as a direct dependency so ADPCM WAV files decode correctly via the existing Decoder::new() path. - Add audio::probe_audio_file() which attempts to construct a Decoder from a copied file before committing it. On failure, the orphan is deleted and the in-memory custom path is cleared so playback falls back to the embedded default cleanly. - Call probe_audio_file() in audio_set_custom after the file is copied; return an Err to the frontend if the format is unsupported. - Add per-cue inline error state to NotificationsSection.svelte so the error message is displayed below the failing row. Error clears on a successful selection or when the user restores the default. - Remove 'flac' from the openAudioFilePicker filter; FLAC decoding is not available and the option was misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related fixes for issue #389, where custom notification sounds silently fell back to the built-in default on Windows.
Root cause: Rodio 0.22 uses Symphonia for decoding. The compiled Symphonia crates only included PCM WAV support. ADPCM-encoded WAV (the default output of Windows Sound Recorder) failed to decode silently, and FLAC — offered in the file picker — was never de-codable. Failures were never surfaced to the user; they would see their filename in settings but hear the wrong sound.
symphonia-codec-adpcmas a direct dependency so ADPCM WAV files decode correctly via the existingDecoder::new()path.audio::probe_audio_file()which attempts to construct a Decoder from a copied file before committing it. On failure, the orphan is deleted and the in-memory custom path is cleared so playback falls back to the embedded default cleanly.probe_audio_file()in audio_set_custom after the file is copied; return anErrto the frontend if the format is unsupported.NotificationsSection.svelteso the error message is displayed below the failing row. Error clears on a successful selection or when the user restores the default.openAudioFilePickerfilter; FLAC decoding is not available, and the option was misleading.