fix(timer): clamp Prime duration to prevent spurious completion#414
Merged
fix(timer): clamp Prime duration to prevent spurious completion#414
Conversation
If a Prime command arrives while the engine is Running or Paused with a duration_secs value less than the current elapsed_secs, the next tick would immediately fire Complete — a silent no-op in normal use, but a real hazard if round duration is shortened in settings mid-round. Clamp the new total_secs to elapsed_secs.saturating_add(1) in both the Running and Paused Prime handlers so the timer always advances at least one tick before completing. Adds two regression tests: one for Prime undershooting in Running phase, one for Prime undershooting in Paused phase (verified on Resume).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Prime command arrives while the engine is Running or Paused with a duration_secs value less than the current elapsed_secs, the next tick would immediately fire Complete — a silent no-op in normal use, but a real hazard if round duration is shortened in settings mid-round.
Clamp the new total_secs to elapsed_secs.saturating_add(1) in both the Running and Paused Prime handlers so the timer always advances at least one tick before completing.
Adds two regression tests: one for Prime undershooting in Running phase, one for Prime undershooting in Paused phase (verified on Resume).