fix: prevent timer from getting stuck after skip or restart#413
Merged
Splode merged 1 commit intoSplode:mainfrom Apr 29, 2026
Merged
fix: prevent timer from getting stuck after skip or restart#413Splode merged 1 commit intoSplode:mainfrom
Splode merged 1 commit intoSplode:mainfrom
Conversation
Late duration sync could hit after a fresh start and push the engine back to Idle. Prime the next round duration without changing phase and cover the race with a regression test.
Owner
|
LGTM. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Timer can get stuck after skipping or restarting round. After that, pressing start/play may do nothing.
Cause
After
skiporreset, timer listener sends a follow-upReconfigureto load next round duration.If user starts next round before that command lands,
Reconfigurecan arrive while engine is already running and force it back toIdle.That leaves engine state out of sync with UI and makes timer appear stuck.
Fix
Add a lightweight
Primecommand to timer engine.Primeupdates stored duration for next round without changing engine phase.Use
Primeinstead ofReconfigurein post-Completeand post-Resetpaths, so next-round duration is updated without interrupting a fresh start.