Skip to content

ghdl yosys plugin#14

Merged
Readon merged 2 commits into
SpinalHDL:masterfrom
NikLeberg:ghdl-yosys-plugin
Jun 20, 2024
Merged

ghdl yosys plugin#14
Readon merged 2 commits into
SpinalHDL:masterfrom
NikLeberg:ghdl-yosys-plugin

Conversation

@NikLeberg

Copy link
Copy Markdown
Contributor

Add the ghdl-yosys-plugin to Yosys.

This is a follow-up after the first PR #11 did fail and had to be reverted. See the previous PR for more information.

This also builds GHDL from source instead of pulling from apt.
@NikLeberg

Copy link
Copy Markdown
Contributor Author

Important note: I also changed the docker.yml github action to test build without releasing them. This could help to prevent future bad PRs to make it into master. I can of coursse also revert that change if it is not wished.

@Readon

Readon commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

Important note: I also changed the docker.yml github action to test build without releasing them. This could help to prevent future bad PRs to make it into master. I can of coursse also revert that change if it is not wished.

I have updated the code in SpinalHDL/SpinalHDL to use latest release version of docker image.

It's not necessary to change the CI here.

@NikLeberg

Copy link
Copy Markdown
Contributor Author

It's not necessary to change the CI here.

It is more specifically for the exact problem we had here:

  • A PR introduced changes that failed in CI once the PR was merged to master.
  • If the CI would have ran once for the PR context, without previous merge to master, the error would have been cought.
  • You would not have had to do the manual revert of the PR.

Its no problem for me to remove the commit, tell me and I'll remove it. Or you could also cherry-pick the other commit.

@Readon

Readon commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

It's not necessary to change the CI here.

It is more specifically for the exact problem we had here:

* A PR introduced changes that failed in CI once the PR was merged to master.

* If the CI would have ran once for the PR context, without previous merge to master, the error would have been cought.

yes, that is necessary.

@NikLeberg NikLeberg force-pushed the ghdl-yosys-plugin branch from a0468c0 to ee50335 Compare June 19, 2024 12:24
@NikLeberg

Copy link
Copy Markdown
Contributor Author

Ok, I removed it.

@Readon

Readon commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

Ok, I removed it.

oh, Sorry, I mean run CI for PR is necessary.

@NikLeberg

Copy link
Copy Markdown
Contributor Author

Added it back.

@Readon Readon merged commit 9c72bcf into SpinalHDL:master Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants