Skip to content

fix crashes with talisman & allow ^chips/mult to proc #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lord-ruby merged 2 commits into from
Aug 20, 2025
Merged

fix crashes with talisman & allow ^chips/mult to proc #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4143e37
fix lovely patch to accomodate for talisman
real-niacat Aug 20, 2025
837e139
^chult now procs but it still reverts
real-niacat Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 22 additions & 21 deletions lovely.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,33 +18,34 @@ assembled_string = assembled_string..(type(subpart) == 'string' and subpart or (
'''
match_indent = true

#i know its ugly but its to make sure it doesnt do stuff when talisman is installed
[[patches]]
[patches.pattern]
target = "functions/common_events.lua"
pattern = "elseif eval_type == 'dollars' then"
position = "before"
payload = '''
elseif eval_type == 'x_chips' then
sound = 'cry_xchip'
amt = amt
text = 'X' .. number_format(amt)
colour = G.C.CHIPS
config.type = 'fade'
config.scale = 0.7
elseif eval_type == 'e_chips' then
sound = 'cry_echips'
amt = amt
text = '^' .. number_format(amt) .. ' ' .. localize('k_chips')
colour = G.C.DARK_EDITION
config.type = 'fade'
config.scale = 0.7
elseif eval_type == 'e_mult' then
sound = 'cry_emult'
amt = amt
text = '^' .. number_format(amt) .. ' ' .. localize('k_mult')
colour = G.C.DARK_EDITION
config.type = 'fade'
config.scale = 0.7
elseif eval_type == 'x_chips' and not (SMODS.Mods["Talisman"] or {}).can_load then
sound = 'cryl_xchip'
amt = amt
text = 'X' .. number_format(amt)
colour = G.C.CHIPS
config.type = 'fade'
config.scale = 0.7
elseif eval_type == 'e_chips' and not (SMODS.Mods["Talisman"] or {}).can_load then
sound = 'cryl_echips'
amt = amt
text = '^' .. number_format(amt) .. ' ' .. localize('k_chips')
colour = G.C.DARK_EDITION
config.type = 'fade'
config.scale = 0.7
elseif eval_type == 'e_mult' and not (SMODS.Mods["Talisman"] or {}).can_load then
sound = 'cryl_emult'
amt = amt
text = '^' .. number_format(amt) .. ' ' .. localize('k_mult')
colour = G.C.DARK_EDITION
config.type = 'fade'
config.scale = 0.7
'''
match_indent = true

Expand Down
4 changes: 2 additions & 2 deletions talisman.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ if SMODS and SMODS.Mods and (not SMODS.Mods.Talisman or not SMODS.Mods.Talisman.
end
end
for _, v in ipairs({
"e_mult",
"e_chips",
"e_mult", "emult", "Emult_mod",
"e_chips", "echips", "Echips_mod",
}) do
table.insert(SMODS.scoring_parameter_keys, v)
end
Expand Down