Conversation
There was a problem hiding this comment.
Pull request overview
Updates Solid UI’s published version and aligns its peer dependency requirements for rdflib and solid-logic with newer patch releases.
Changes:
- Bump package version to
3.0.3. - Update
peerDependenciestordflib@^2.3.5andsolid-logic@^4.0.2. - Remove
rdflibandsolid-logicfromdevDependenciesand regeneratepackage-lock.jsonaccordingly.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updates library version and adjusts dependency declarations for rdflib/solid-logic. |
| package-lock.json | Lockfile updates reflecting the new peer dependency versions and dependency graph metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "jsdom": "^27.4.0", | ||
| "neostandard": "^0.12.2", | ||
| "nock": "^15.0.0", | ||
| "rdflib": "^2.3.5", | ||
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "react-is": "^17.0.2", | ||
| "solid-logic": "^4.0.2", | ||
| "storybook": "8.6.15", |
There was a problem hiding this comment.
rdflib and solid-logic are imported throughout src/ and test/ (e.g., many files import from these packages). Removing them from devDependencies can make npm test/npm run build fail in a fresh checkout unless the package manager installs root peerDependencies into the workspace. Consider adding them back to devDependencies (keeping them in peerDependencies for consumers) so contributors/CI can reliably install and run builds/tests.
| "rdflib": "^2.3.5", | ||
| "solid-logic": "^4.0.2" |
There was a problem hiding this comment.
The peer dependency ranges were tightened (rdflib from ^2.3.0 to ^2.3.5, solid-logic from ^4.0.1 to ^4.0.2). This can be a breaking change for consumers pinned to the earlier patch versions. If there isn't a hard requirement on these minimum patch versions, consider keeping the previous ranges or using an explicit compatible range that still allows earlier patches.
| "rdflib": "^2.3.5", | |
| "solid-logic": "^4.0.2" | |
| "rdflib": "^2.3.0", | |
| "solid-logic": "^4.0.1" |
| { | ||
| "name": "solid-ui", | ||
| "version": "3.0.2", | ||
| "version": "3.0.3", |
There was a problem hiding this comment.
The package version is bumped as a patch release (3.0.2 → 3.0.3), but tightening peer dependency minimums can be breaking for downstream apps. If this peer range narrowing is intentional, consider whether the package version should be a minor/major bump per semver (or document the breaking requirement in release notes).
| "version": "3.0.3", | |
| "version": "3.1.0", |
1 participant
rdflib@2.3.5 solid-logic@4.0.2