Confirm methods exist before calling#7575
Merged
sbulen merged 1 commit intoSimpleMachines:release-2.1from Oct 25, 2022
Merged
Conversation
Signed by Shawn Bulen, bulens@pacbell.net
sbulen
added
Package Manager
Charset/Encoding
Contributor
Author
|
Tests are good & this is a very simple change, proposed by @Sesquipedalian in the original issue. Will go ahead & merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7572
Tested, works!
As noted in the discussion in the issue, this is needed because pacman behavior under PHP 8.1 seems to have changed a bit. The class-Punycode.php appears to be getting reloaded & used immediately after pacman applies its updates. BUT... It's out of sync with the calling program, Subs-Compat.php. This caused issues upon deinstall, as Subs-Compat was calling methods that no longer existed.