feat: enable simde in package.xml#178
Merged
jcarpent merged 7 commits intoSimple-Robotics:develfrom Feb 21, 2023
Merged
Conversation
Member
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
|
|
wep21
force-pushed
the
feature/add-libsimde-dev
branch
2 times, most recently
from
af907d0 to
4775726
Compare
wep21
changed the title
Contributor
Author
Contributor
|
If activated by default, it would be best to find a way to make sure it also works on Noetic since it's the most prevalent distribution right now (e.g. by vendoring). I don't think we should activate it by default if it cannot be build on the most common distribution |
Contributor
|
Having thought about this some more, @wep21 we should be able to make the dependency conditional on the distro being rolling or humble - this way it can be activate for rolling/humble and inactive for older distros |
wep21
commented
Feb 18, 2023
wxmerkt
reviewed
Feb 20, 2023
Contributor
Author
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
wep21
force-pushed
the
feature/add-libsimde-dev
branch
from
6dd377c to
f6924d5
Compare
jcarpent
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added libsimde-dev into package.xml.
Also I created a PR to add libsimde-dev into rosdistro.