Fix encoding span polyfills for empty spans#570
Merged
SimonCropp merged 1 commit intoJul 15, 2026
Conversation
Owner
|
nice. will deploy now |
This was referenced Jul 15, 2026
2 tasks
This was referenced Jul 15, 2026
This was referenced Jul 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encodingspan overloads for empty inputEncoder.ConvertRoot cause
Pinning an empty span produces a null pointer. The pointer-based encoding overloads reject null pointers even when the corresponding length is zero, unlike the native span overloads.
Validation
dotnet run --project src/ApiBuilderTests/ApiBuilderTests.csproj --configuration Debug— 71 passeddotnet build src/Polyfill.slnx --configuration Release— succeeded, 0 errorspwsh ./src/run-tests.ps1— full project/framework matrix passedCloses #569