Skip to content

Prevent workspace_dependencies failing if directory gets removed during execution#3980

Open
vinistock wants to merge 1 commit intomainfrom
02-26-prevent_workspace_dependencies_failing_if_directory_gets_removed_during_execution
Open

Prevent workspace_dependencies failing if directory gets removed during execution#3980
vinistock wants to merge 1 commit intomainfrom
02-26-prevent_workspace_dependencies_failing_if_directory_gets_removed_during_execution

Conversation

@vinistock
Copy link
Member

@vinistock vinistock commented Feb 26, 2026

Motivation

We got some cases in telemetry of this scenario:

  • User starts running the LSP on a directory
  • User goes on the terminal and deletes the directory where the LSP is running

This makes Dir.pwd crash deep inside Bundler on workspace_dependencies.

Implementation

The fix is simple, we just rescue in this case. There's not much we can do if the user deleted the workspace other than avoid crashing.

Automated Tests

Added a test that reproduces the issue.

@vinistock vinistock self-assigned this Feb 26, 2026
@vinistock vinistock added the bugfix This PR will fix an existing bug label Feb 26, 2026 — with Graphite App
Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock added the server This pull request should be included in the server gem's release notes label Feb 26, 2026 — with Graphite App
@vinistock vinistock marked this pull request as ready for review February 26, 2026 15:10
@vinistock vinistock requested a review from a team as a code owner February 26, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant