Fix infinite loop when collecting transitive excluded gems#3913
Merged
rafaelfranca merged 1 commit intomainfrom Jan 22, 2026
Merged
Fix infinite loop when collecting transitive excluded gems#3913rafaelfranca merged 1 commit intomainfrom
rafaelfranca merged 1 commit intomainfrom
Conversation
rafaelfranca
added
bugfix
vinistock
approved these changes
Jan 22, 2026
The code was modifying the `excluded` array while iterating over it with `.each`. In Ruby, `.each` continues to process newly added elements, which can cause excessive iterations or infinite loops when circular dependencies are present in the gem graph. This caused 100% CPU usage in some environments. Fixes #3912
rafaelfranca
force-pushed
the
rm-fix-loop
branch
from
c3e7710 to
279f32f
Compare
|
That was fast @rafaelfranca @vinistock 🚀 Thank you very much gentlemen, greetings from Argentina. Will confirm it's working in the next release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was modifying the
excludedarray while iterating over it with.each. In Ruby,.eachcontinues to process newly added elements, which can cause excessive iterations or infinite loops when circular dependencies are present in the gem graph.This caused 100% CPU usage in some environments.
Fixes #3912