Fix bare heredoc syntax highlighting#3909
Merged
rafaelfranca merged 1 commit intoShopify:mainfrom Jan 20, 2026
Merged
Conversation
rafaelfranca
approved these changes
Jan 20, 2026
rafaelfranca
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3908
Implementation
The primary change is changing the grammar to use
<<[-~]?instead of<<[-~], since heredocs don't strictly require a dash or tilde. This is changed in a number of places, as there are specific regexes for each language-specific heredoc type (e.g.<<SQL), but it's all the same change.Automated Tests
See the included automated tests.
Manual Tests
I started a new VSCode window with this change and confirmed that it was highlighted as expected with both regular heredocs and language-specific tags.
Highlighting works:
Token types look correct:
