Fix multiline RBS signature dimming#3864
Merged
vinistock merged 1 commit intoShopify:mainfrom Dec 15, 2025
Merged
Conversation
Contributor
Author
|
I have signed the CLA! |
Contributor
Author
|
Hi @vinistock 👋 I was experimenting with RBS Sigs and ran into the bug described in #3860, so I took a shot at fixing it in this PR. My main concern is that I couldn't find a good way to unit test the decorations. I saw we have grammar tests for tokenization but didn't spot a place or pattern for testing the decoration itself. Would appreciate any guidance on that. I'd love to get your review on this — it's my first contribution to ruby-lsp! |
vinistock
added
bugfix
vinistock
approved these changes
Dec 15, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Thank you for the contribution! We indeed don't have tests for this particular decoration yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3860
Manual Tests