Conversation
This reverts commit 8cbd8f8.
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
adsteel
left a comment
There was a problem hiding this comment.
Today I commented out these lines and my issues went away.
|
FWIW if you need better reproduction steps when re-introducing this, I was able to consistently crash diagnostics the other day by doing a find-and-replace on 10+ files, which caused a violation of our linelength setting (e.g. replace It seemed to cause bizarre corruption of the file, with spaces and such randomly thrown in, and crashed diagnostics even after I fully restarted my editor to try it again. |
|
Thank you @connorshea, that's really helpful. We had other reports of find and replace producing weird results too, so it seems like the most reliable way of reproducing it. |
Closes #3809
Unfortunately, we continue to receive reports of issues related to trying to reuse the Prism result for RuboCop. Let's revert this for now and make time to investigate in more detail.